chore: update aic computation in impact efficiency report#39585
Merged
Conversation
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
…flow.json Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
…lity guidance Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
mnkiefer
June 16, 2026 15:56
View session
mnkiefer
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes missing/zero AI Credits (AIC) in the Impact Efficiency Report by introducing a deterministic, aggregated AIC dataset sourced from daily token-audit “memory” snapshots, and updating the report workflow to prioritize that dataset over workflow-run logs.
Changes:
- Add generation of
aic-by-workflow.jsonby aggregating daily snapshots from thememory/token-auditbranch across the 180-day window. - Extend
dataset-manifest.jsonwith provenance/coverage fields for the aggregated AIC dataset. - Update the Impact Efficiency Report workflow instructions to require and prioritize
aic-by-workflow.jsonfor AIC.
Show a summary per file
| File | Description |
|---|---|
| scripts/prepare-objective-impact-report-dataset.sh | Fetches and aggregates token-audit daily snapshots into aic-by-workflow.json, and adds manifest provenance fields. |
| .github/workflows/objective-impact-report.md | Requires aic-by-workflow.json and updates AIC source-of-truth guidance to use it as primary. |
| .github/workflows/objective-impact-report.lock.yml | Regenerated lock file reflecting the workflow markdown updates. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 3
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Collaborator
|
@copilot Resolve conflicts |
…fix-aic-computation # Conflicts: # .github/workflows/objective-impact-report.lock.yml Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Contributor
Author
Resolved in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh aw logs --start-date -180dreturns 0 runs, causing every Impact Efficiency Report to show AIC = 0 and Impact Efficiency = undefined. Thegh-api-fallbackpath also always setsaic: null, so neither code path was producing usable cost data.Changes
scripts/prepare-objective-impact-report-dataset.shmemory/token-auditbranch (written daily by the AIC Usage Audit) and aggregates all daily snapshots within the 180-day window into a newaic-by-workflow.jsondatasettotal_aicandrun_countper workflow; entries are summed across all matching daysdataset-manifest.jsonwithaic_by_workflow_source,aic_by_workflow_snapshot_count, andaic_by_workflow_totalfor provenance.github/workflows/objective-impact-report.mdaic-by-workflow.jsonto required inputsaic-by-workflow.jsonis now primary;workflow-logs.jsonis fallback onlypr-sous-chef: requested branch update for https://github.com/github/gh-aw/actions/runs/27631101484